Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upgrade various dependencies and fix warnings in Flutter package #844

Merged
merged 9 commits into from
Mar 19, 2023
Merged

feat: Upgrade various dependencies and fix warnings in Flutter package #844

merged 9 commits into from
Mar 19, 2023

Conversation

mbfakourii
Copy link
Member

New Pull Request Checklist

Issue Description

All versions and packages in the Flutter package have been updated to the latest version and the warnings have been fixed

Closes: #821

Approach

n/a

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry

@parse-github-assistant
Copy link

parse-github-assistant bot commented Mar 7, 2023 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Mar 7, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (2302649) 26.35% compared to head (5c93ab6) 26.35%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #844   +/-   ##
=======================================
  Coverage   26.35%   26.35%           
=======================================
  Files          47       47           
  Lines        2903     2903           
=======================================
  Hits          765      765           
  Misses       2138     2138
Impacted Files Coverage Δ
...ackages/flutter/lib/src/utils/parse_live_grid.dart 0.00% <0.00%> (ø)
...ackages/flutter/lib/src/utils/parse_live_list.dart 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mbfakourii
Copy link
Member Author

@mtrezza
What is the need for codecov/patch Failing after 1s — 0.00% of diff hit (target 16.36%) checks if it always says wrong, in my opinion, the test should be chosen by the managers for the PR owner.

@mtrezza
Copy link
Member

mtrezza commented Mar 7, 2023

It's probably a minimum coverage that is expects?

@mbfakourii
Copy link
Member Author

It's probably a minimum coverage that is expects?

No, by the way, many lines say to write a test, which is not necessary

@mbfakourii mbfakourii mentioned this pull request Mar 8, 2023
Merged
5 tasks
@mbfakourii mbfakourii requested a review from a team March 8, 2023 05:53
@mtrezza
Copy link
Member

mtrezza commented Mar 8, 2023

Let's look at the coverage in a separate issue then.

@mtrezza
Copy link
Member

mtrezza commented Mar 8, 2023 •
edited
Loading

This is a breaking change, as it upgrades to nio 5 and parse dart 4. So I'd merge this together with the breaking change of package renaming. Other than that it looks good.

@mtrezza mtrezza added the state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message label Mar 8, 2023
Nidal-Bakir
Nidal-Bakir previously approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@Nidal-Bakir Nidal-Bakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nidal-Bakir added a commit to Nidal-Bakir/Parse-SDK-Flutter that referenced this pull request Mar 8, 2023
@Nidal-Bakir
revert: the last two commits conflict with PR parse-community#844
ff38685 
Revert "bump dependencies versions for the Flutter package"

Revert "chore: bump the flutter sdk version to 4.0.0 and add change log entry"

This reverts commit
67d9512
dae1d47
@mtrezza mtrezza mentioned this pull request Mar 10, 2023
Closed
4 tasks
@Nidal-Bakir
Copy link
Member

@mtrezza
this

mtrezza
mtrezza requested changes Mar 18, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a changelog entry

@mtrezza mtrezza changed the title feat: Upgrade various dependencies and fix warnings in flutter package feat: Upgrade various dependencies and fix warnings in Flutter package Mar 18, 2023
@mtrezza
Copy link
Member

mtrezza commented Mar 18, 2023

Once this is merged, we can publish the flutter 4.0 release.

@mbfakourii
Copy link
Member Author

flutter version bumped and entry added in CHANGELOG.md

Nidal-Bakir
Nidal-Bakir previously approved these changes Mar 19, 2023
View reviewed changes
mtrezza
mtrezza requested changes Mar 19, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To give more details about the changelog convention we're using across Parse Platform:

  • a feat PR must have an entry in the ### Features section which is (except in specific cases) the same as the PR title
  • the ### BREAKING CHANGES section is an additional section in which a PR that includes a breaking change must make a note in addition to the entry in the ### Features section; it's where more details can be added to help developers adapt to the breaking change, such as links to migration guides, other GitHub issues, etc.
  • the entries mentioned above always reference the GitHub pull request, not the GitHub issue; that's because a commit may not have an issue associated with it, but it (usually) always has a pull request; in the past we were sometimes referencing issues which we don't do anymore.

I'll commit the changes.

Are we ready to release Flutter 4.0 after this PR has been merged?

@Nidal-Bakir
Copy link
Member

Yes, we are ready for 4.0.0

@mtrezza
Copy link
Member

mtrezza commented Mar 19, 2023

Great, let's wait for @mbfakourii's confirmation as well, then I'll go ahead and merge.

@mbfakourii
Copy link
Member Author

Great, let's wait for @mbfakourii's confirmation as well, then I'll go ahead and merge.

For now, let's move to a higher version. We need more time to discuss the merge of the two libraries.

mtrezza
mtrezza approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mtrezza mtrezza merged commit 8d17772 into parse-community:master Mar 19, 2023
@mbfakourii mbfakourii deleted the update_flutter_version branch May 23, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

@Nidal-Bakir Nidal-Bakir Nidal-Bakir approved these changes

Assignees
No one assigned
Labels
state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade dependency package_info_plus
3 participants
@mbfakourii @mtrezza @Nidal-Bakir